-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make terminal draggable #4340
Open
Marckon
wants to merge
13
commits into
opensumi:main
Choose a base branch
from
Marckon:feat/move-terminal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
664dbff
feat: layout service add moveContainerTo api
Marckon 01a1af2
chore: need right container to move to show
Marckon 91a86cc
feat: register drop area in main-layout pkg
Marckon dbd52e9
feat: complete drag behavior
Marckon e2d8184
feat: tabbarHandler should change
Marckon 13ec70c
feat: toggle slot ignore drop container
Marckon 5baa839
fix: optimize code and fix initial layout storage
Marckon 430c44d
Merge branch 'main' into feat/move-terminal
Marckon 8e4dceb
chore: add i18n and fix ci problem
Marckon f84098b
feat: hide terminal right tab icon
Marckon e76df6c
Merge branch 'main' into feat/move-terminal
Ricbet 2133de9
chore: add a space char in comment line
Marckon e1b75e5
chore: useCallback in titlebar.view
Marckon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 27 additions & 2 deletions
29
packages/main-layout/src/browser/accordion/titlebar.view.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import React from 'react'; | ||
|
||
import { localize, useInjectable } from '@opensumi/ide-core-browser'; | ||
|
||
import { IMainLayoutService } from '../../common'; | ||
|
||
import styles from './styles.module.less'; | ||
|
||
interface IDropAreaProps { | ||
location: string; | ||
} | ||
|
||
const DropArea: React.FC<IDropAreaProps> = (props) => { | ||
const { location } = props; | ||
const layoutService = useInjectable<IMainLayoutService>(IMainLayoutService); | ||
|
||
const handleDrop = React.useCallback( | ||
(e: React.DragEvent) => { | ||
const containerId = e.dataTransfer?.getData('containerId'); | ||
layoutService.moveContainerTo(containerId, location); | ||
}, | ||
[layoutService, location], | ||
); | ||
|
||
return ( | ||
<div | ||
className={styles.drop_area} | ||
onDrop={handleDrop} | ||
onDragOver={(e) => { | ||
e.preventDefault(); | ||
}} | ||
> | ||
{localize('main-layout.drop-area.tip')} | ||
</div> | ||
); | ||
}; | ||
|
||
export const RightDropArea = () => <DropArea location='right' />; | ||
|
||
export const BottomDropArea = () => <DropArea location='bottom' />; |
7 changes: 7 additions & 0 deletions
7
packages/main-layout/src/browser/drop-area/styles.module.less
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
.drop_area { | ||
width: 100%; | ||
height: 100%; | ||
display: flex; | ||
align-items: center; | ||
justify-content: center; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里尽量给到明确的 类 样式,统配的 div 可能会给后面修改 dom 结构带来样式问题