-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Inline input rendering error with a single stream chunk. #4348
Conversation
/next |
Walkthrough此次变更在 InlineInputController 的 showInputInSelection 方法中增加了对 chatResponse.listen() 的调用,使得在符合条件的情况下能够实时监听来自聊天响应的数据。同时,对代码整体组织结构进行了细微调整,没有更改公开实体的声明。 Changes
Sequence Diagram(s)sequenceDiagram
participant C as InlineInputController
participant R as chatResponse
C->>C: 执行 showInputInSelection 方法
alt 条件满足 (previewResponse 为 InlineChatController 实例)
C->>R: 调用 listen() 开始监听实时更新
end
Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
yarn install v1.22.22 ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/ai-native/src/browser/widget/inline-input/inline-input.controller.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: 🚀🚀🚀 Next Version for pull request
- GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
- GitHub Check: unittest (ubuntu-latest, 18.x, node)
- GitHub Check: build (ubuntu-latest, 20.x)
- GitHub Check: unittest (macos-latest, 18.x, jsdom)
- GitHub Check: build (macos-latest, 20.x)
- GitHub Check: unittest (macos-latest, 18.x, node)
- GitHub Check: build-windows
- GitHub Check: ubuntu-latest, Node.js 20.x
|
||
chatResponse.listen(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修复了单个数据流块的渲染问题
通过在挂载 diff previewer 后立即调用 chatResponse.listen()
,确保了聊天响应流的正确初始化和监听,从而解决了单个数据流块的渲染异常问题。
🎉 PR Next publish successful! 3.7.1-next-1739004986.0 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4348 +/- ##
==========================================
- Coverage 54.15% 54.14% -0.01%
==========================================
Files 1639 1639
Lines 100310 100310
Branches 21770 21762 -8
==========================================
- Hits 54322 54316 -6
- Misses 38214 38219 +5
- Partials 7774 7775 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Types
Background or solution
Changelog
修复 inline input 在只有一条流式数据块时渲染异常的问题
Summary by CodeRabbit