Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): fix state updates on unmounted component #10

Merged
merged 1 commit into from
May 19, 2022

Conversation

crimx
Copy link
Contributor

@crimx crimx commented May 19, 2022

keymapChangeDelayer.trigger delays the execution of callback which may cause state updates triggered on unmounted component.

@CLAassistant
Copy link

CLAassistant commented May 19, 2022

CLA assistant check
All committers have signed the CLA.

@yantze
Copy link
Member

yantze commented May 19, 2022

LGTM

@yantze yantze merged commit f64442f into opensumi:main May 19, 2022
@crimx crimx deleted the fix-empty-editor branch May 19, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants