This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix S3 permissions to allow CloudFront logging #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colekettler
commented
Jan 12, 2021
| bucket = "${aws_s3_bucket.logs.id}.s3.amazonaws.com" | ||
| bucket = "${aws_s3_bucket.logs.bucket_domain_name}" |
There was a problem hiding this comment.
These two create no diff in the plan, but using bucket_domain_name requires less manual stringiness.
colekettler
commented
Jan 12, 2021
Comment on lines
+276
to
+278
| variable "aws_cloudfront_canonical_user_id" { | ||
| default = "c4c1ede66af53448b93c283ce9448c4ba468c9432aa01d700d3878632f77d2d0" | ||
| } |
There was a problem hiding this comment.
We need to hardcode this magic ID until hashicorp/terraform-provider-aws#12512 is merged.
There was a problem hiding this comment.
👍
We should consider opening an issue in the backlog so we have something to remind us to clean this up.
There was a problem hiding this comment.
Tracked in #1209!
hectcastro
approved these changes
Jan 12, 2021
colekettler
force-pushed
the
feature/cek/cloudfront-logging
branch
from
fb61951 to
633d33e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Creates grants to prevent Terraform removing implicit grants that are usually created by AWS when creating a CloudFront distribution through the console. These grants have recently become necessary for CloudFront to persist access logs to S3.
The AWS canonical user grant replicates the permissions granted by the
privatecanned ACL, and the CloudFront canonical user ID replicates the permissions granted when creating a distribution through the console.Testing Instructions
Checklist
fixup!commits have been squashed