Licensing fixes #42
Merged
Licensing fixes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This (partly) fixes the license incompatibility reported in opensvc#36 As I'm the only author (except for a trivial spelling fix), I see no issue with changing the license. Signed-off-by: Martin Wilck <mwilck@suse.com>
In uxclnt.c, there are isspace calls. Add an explicit include. Signed-off-by: Bastian Germann <bage@debian.org> Reviewed-by: Martin Wilck <mwilck@suse.com> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Linking multipathd with libreadline may cause a license conflict, because libreadline is licensed under GPL-3.0-or-later, and libmultipath contains several files under GPL-2.0. See: opensvc#36 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979095 https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility Replace the readline functionality with libedit, which comes under a BSD license. The readline library can still be enabled (e.g. for binaries not intended to be distributed) by running "make READLINE=libreadline". Signed-off-by: Martin Wilck <mwilck@suse.com> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
This is is required after switching from libreadline to libedit. Signed-off-by: Martin Wilck <mwilck@suse.com>
This is is required after switching from libreadline to libedit. Signed-off-by: Martin Wilck <mwilck@suse.com>
This is is required after switching from libreadline to libedit. Signed-off-by: Martin Wilck <mwilck@suse.com>
This is is required after switching from libreadline to libedit. On jessie, we can use libreadline5 (libreadline-gpl2-dev) without license issues. Trying to compile against libedit results in an "incompatible pointer type" error on jessie, because libedit uses a different prototype for rl_completion_entry_function. Signed-off-by: Martin Wilck <mwilck@suse.com>
Building the containers in the build-multipath project recently started failing for buster/s390x and buster/ppc64el. That failure had nothing to do with the switch to libedit. It's about time to switch to bullseye anyway. Signed-off-by: Martin Wilck <mwilck@suse.com>
|
The CI breaks because of the switch to libedit. I am pushing fixes to the GitHub workflows that should fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting this from a separate branch to keep it isolated from the technical patches in the
queuebranch. @cvaroqui, please merge ASAP.Fixes #36.
This is a first set of patches for the GPL 2.0/3.0 issue.
Another, additional set of licensing-related patches has been submitted to dm-devel and will improve the situation further. I'm submitting here nonetheless because the basic fix should be applied quickly.
Bastian Germann (1):
multipathd: Add missing ctype include
Martin Wilck (7):
libmultipath: convert license of strbuf code to GPL-2.0+
multipathd: replace libreadline with libedit
github workflows: build-and-unittest.yaml: add libedit-dev
github workflows: coverity.yaml: add libedit-dev
github workflows: abi.yaml: add libedit-dev
GitHub workflows: native.yaml: add libedit-dev, except for jessie
GitHub workflows: foreign.yaml: switch to Debian 11 (bullseye)