Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renovate.json to group updates #112

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Update renovate.json to group updates #112

merged 1 commit into from
Mar 22, 2024

Conversation

acolchado
Copy link
Collaborator

No description provided.

"description": "All packages related to spur node framework"
},
{
"packagePatterns": ["prettier", "-prettier"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prettier also cover prettier-?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no. I'll have to recheck but it required it in another repo.

"description": "All packages related to the eslint plugin"
},
{
"packagePatterns": ["jest", "@types/jest", "nock", "jest-"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to extend from Renovate's built-in Jest + types group? group:jestPlusTypes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I'll review this as a whole. I also recall Arnold mentioning that we have predefined config so I don't have to do this, but have not done the research yet. For now I am sticking to the common config we use.

Copy link
Contributor

@terry-au terry-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two comments but nothing blocking.

@acolchado acolchado merged commit dfdadf4 into main Mar 22, 2024
3 checks passed
@acolchado acolchado deleted the acolchado-patch-1 branch March 22, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants