refactor(colors): Removal of chalk coloring messages #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The colorization of these messages do not add anything substantial to the logs unless they are running locally. Removing it does however helps make this package more secure. There has been a few security concerns that chalk has exposed this framework to because of the low maintenance effort. While spur-ioc and all other spur-packages will be going into maintenance mode, we are actively reducing any change that a new security concern can be discovered down the road due to a dependency. If you want to see the colors, you can stick to the previous version of spur-ioc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colorization of these messages do not add anything substantial to the logs unless they are running locally.
Removing it does however helps make this package more secure. There has been a few security concerns that chalk has exposed this framework to because of the low maintenance effort.
While spur-ioc and all other spur-packages will be going into maintenance mode, we are actively reducing any change that a new security concern can be discovered down the road due to a dependency.
If you want to see the colors, you can stick to the previous version of spur-ioc.