Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): [RO-18670] add ability to ignore dependencies #80

Merged
merged 1 commit into from
May 17, 2023
Merged

feat(*): [RO-18670] add ability to ignore dependencies #80

merged 1 commit into from
May 17, 2023

Conversation

terry-au
Copy link
Contributor

  • FIx logging.

@terry-au terry-au changed the base branch from main to v2.0.0 May 17, 2023 06:53
@terry-au terry-au closed this May 17, 2023
@terry-au terry-au reopened this May 17, 2023
@terry-au terry-au force-pushed the RO-18670-Extend-spur-ioc-to-add-the-ability-to-skip-dependency-registration branch from 60f8dba to 0e4e4f6 Compare May 17, 2023 06:57
@acolchado acolchado merged commit 7f1b379 into opentable:v2.0.0 May 17, 2023
acolchado pushed a commit that referenced this pull request Jun 13, 2023
@terry-au @acolchado
feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependen…
a92cb5e 
…cy registration (#80)

fix logging
acolchado added a commit that referenced this pull request Jun 13, 2023
@acolchado @terry-au
Merges the 2.0.0 release candidate branch (#89)
e517276 
* Adds the ability to read the typescript files (#76)

This addition is not meant to be full support of typescript from the library. It's meant to allow the reading of the files in the case you are looking to use TS files and are responsible for the transpilation/compilation of those files.

We are experimenting adding this to allow us to use ts files with ts-jest and other tooling in our tests and source files. The compilation is happening locally and doesn't depend on the package having full support for a build pipeline.

This will be published a major version so that those who may have .ts files won't have a break in their dev flow but once it's promoted out of release candidate, it will have proper documentation if we opt to keep the support.

* v2.0.0-rc.0 (#77)

* feat(*): [RO-18670] add ability to ignore dependencies (#78)

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
add support for skipping dependency injection by setting

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
improve logging output when warning against dependency registration collisions

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
fix passing incorrect parameters
improve logging

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
add warning for ignored dependencies

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
add test cases for registerFolders and addResolvableDependency

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
add test cases for addDependency

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
update FileFilterExpression to ignore .d.ts files
add test

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
fix file filter causing issues with some imports
update logging to print primitive types

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration
added missing lodash.get dependency

* feat(*): RO-18670 Extend spur-ioc to add the ability to skip dependency registration (#80)

fix logging

* v2.0.0-rc.1 (#79)

* refactor(warnings): Removes the noisy ignored dependency warnings (#81)

* v2.0.0-rc.2 (#82)

---------

Co-authored-by: Terry Lewis <terry1994dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolchado acolchado acolchado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terry-au @acolchado