Add some basic tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirandaio
suggested changes
Aug 12, 2018
package.json
Outdated
| @@ -18,6 +18,8 @@ | |||
| "apollo-link-schema": "^1.1.0", | |||
| "casual-browserify": "^1.5.19-2", | |||
| "d3": "^5.5.0", | |||
| "enzyme": "^3.3.0", | |||
| "enzyme-adapter-react-16": "^1.1.1", | |||
There was a problem hiding this comment.
enzyme and enzyme-adapter-react-16 should be in devDependencies.
There was a problem hiding this comment.
I think that would be clearer; moving them now.
The create-react-app README describes setting up enzyme and installs them as dependencies, not devDependencies. Discussed here.
package.json
Outdated
| @@ -31,6 +33,7 @@ | |||
| "react-measure": "^2.1.0", | |||
| "react-router-dom": "^4.3.1", | |||
| "react-scripts": "1.1.4", | |||
| "react-test-renderer": "^16.4.2", | |||
There was a problem hiding this comment.
I think this should also be in devDependencies.
mirandaio
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
yarn test:coveragescript