feat(core): KID in NanoTDF #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new enum for identifier length and modifies the ResourceLocator class to include this identifier and its encoding/decoding logic. This enhances the resource locator functionality by supporting identifiers of varying lengths.
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
Signed-off-by: Paul Flynn <pflynn@virtru.com>
pflynn-virtru
force-pushed
the
feature/nano-kid
branch
from
a87e092
to
8262fbd
Compare
Corrected the bitwise operation for identifier type nibble check to accurately detect the 'None' type. Also removed an outdated TODO comment related to padding in identifier decoding.
Initialize `identifierType` to `None` explicitly before evaluating the protocol nibble. This simplifies the conditional logic by setting a default value upfront and adjusting it only when specific conditions are met.
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
Initialized `identifierType` to `ResourceLocatorIdentifierEnum.None` by default in the `ResourceLocator` model. Removed redundant assignment in constructor and adjusted identifier length calculation accordingly. Signed-off-by: Paul Flynn <pflynn@virtru.com>
pflynn-virtru
force-pushed
the
feature/nano-kid
branch
from
42211e6
to
bcef48d
Compare
Changed the allocation of the buffer to use identifierType.valueOf() instead of this.identifier.length. This ensures accurate buffer sizing based on the identifier type's value.
Changed the allocation of the buffer to use identifierType.valueOf() instead of this.identifier.length. This ensures accurate buffer sizing based on the identifier type's value. Signed-off-by: Paul Flynn <pflynn@virtru.com>
pflynn-virtru
force-pushed
the
feature/nano-kid
branch
from
2de3c0d
to
aa8a011
Compare
Included new test cases to verify the parsing logic of the ResourceLocator identifiers in different byte formats such as two bytes, eight bytes, and thirty-two bytes. This ensures that the identifier type and value are correctly parsed and validated.
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
pflynn-virtru
force-pushed
the
feature/nano-kid
branch
from
00d825c
to
c548f4f
Compare
Signed-off-by: Paul Flynn <pflynn@virtru.com>
pflynn-virtru
force-pushed
the
feature/nano-kid
branch
from
c548f4f
to
0b587f6
Compare
Streamline the identifier extraction by removing padding bytes before decoding. This change accounts for null byte padding that was previously being included in the identifier, ensuring cleaner and more accurate decoding.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NanoTDF will now have the KAS KID set in the KAS ResourceLocator
Introduces a new enum for identifier length and modifies the ResourceLocator class to include this identifier and its encoding/decoding logic. This enhances the resource locator functionality by supporting identifiers of varying lengths.
Resolves #311
Specification: opentdf/spec#40
ADR: opentdf/platform#900