feat(core): KID in NanoTDF #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced an IdentifierType enum to categorize different identifier lengths. Updated ResourceLocator constructors to handle identifiers, including parsing and setting appropriate identifier types. Modified ByteBuffer constructor to extract identifier information from the protocol byte.
Replaced string literals for protocol matching with constants and removed unnecessary identifier length variables, streamlining the class. Adjusted identifier handling to directly utilize the array length for type determination, enhancing readability and performance.
Corrected the byte manipulation for protocol and identifier nibbles in ResourceLocator. Removed commented-out identifier types in NanoTDFType and added a new method to retrieve the identifier in ResourceLocator. Added an assertion to ensure the identifier is not null during ResourceLocator creation in NanoTDF.
Enhanced `ResourceLocator` to handle various identifier lengths and added JUnit tests to verify correctness. Updated the `writeIntoBuffer` method to accurately write the identifier based on its type, and added detailed class documentation for better understanding.
Added final modifiers to method parameters in ResourceLocator class. Introduced a new method setIdentifier and refactored identifier length handling with system array copy. Modified NanoTDFType to include identifier length constants, and updated tests to reflect these changes.
This modification adds the KID attribute to the ResourceLocator constructor, enhancing the instantiation process. The inclusion ensures that the identifier is properly managed and non-null within NanoTDF operations.
Introduce a static final KID constant to improve readability and reduce repetition. Update related code segments to use this constant and ensure proper handling of UTF-8 encoding.
dmihalcik-virtru
approved these changes
Aug 14, 2024
mkleene
pushed a commit
that referenced
this pull request
Aug 19, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>0.5.0</summary> ## [0.5.0](v0.4.0...v0.5.0) (2024-08-19) ### Features * BACK-2316 add a simple method to detect TDFs ([#111](#111)) ([bfbef70](bfbef70)) * **cmd:** Adds command `--mime-type` opt ([#113](#113)) ([45a2c30](45a2c30)) * **core:** Add attributes client ([#118](#118)) ([98ba6a9](98ba6a9)) * **core:** Handle split keys on tdf3 encrypt and decrypt ([#109](#109)) ([943751f](943751f)) * **core:** KID in NanoTDF ([#112](#112)) ([33b5982](33b5982)) * **sdk:** Update the assertion support to match go sdk ([#117](#117)) ([f9badb3](f9badb3)) ### Bug Fixes * Issue [#115](#115) - fix for SSL Context for IDP and plaintext platform ([#116](#116)) ([36a29df](36a29df)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
This was referenced Aug 27, 2024
pflynn-virtru
pushed a commit
that referenced
this pull request
Oct 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>0.7.2</summary> ## [0.7.2](v0.7.0...v0.7.2) (2024-10-08) ### ⚠ BREAKING CHANGES * move to single jar ([#160](#160)) ### Features * add code to create services for SDK ([#35](#35)) ([28513e6](28513e6)) * add logging ([#49](#49)) ([9d20647](9d20647)) * Add NanoTDF E2E Tests ([#75](#75)) ([84f9bd1](84f9bd1)) * adds token exchange and general auth ([#176](#176)) ([bb325c4](bb325c4)) * BACK-2316 add a simple method to detect TDFs ([#111](#111)) ([bfbef70](bfbef70)) * **build:** maven refactor for maven central ([#174](#174)) ([c640773](c640773)), closes [#79](#79) * **ci:** Add xtest workflow trigger ([#96](#96)) ([bc54b63](bc54b63)) * **cmd:** Adds command `--mime-type` opt ([#113](#113)) ([45a2c30](45a2c30)) * **cmdline:** Adds --ecdsa-binding and help ([#164](#164)) ([ed6e982](ed6e982)) * **codegen:** Generate and publish Java Proto generated artifacts ([#2](#2)) ([2328fd2](2328fd2)) * **core:** Add attributes client ([#118](#118)) ([98ba6a9](98ba6a9)) * **core:** Add autoconfigure for key splitting ([#120](#120)) ([7ecbf23](7ecbf23)) * **core:** Adding key cache, tests for specificity ([#126](#126)) ([a149887](a149887)) * **core:** Handle split keys on tdf3 encrypt and decrypt ([#109](#109)) ([943751f](943751f)) * **core:** KID in NanoTDF ([#112](#112)) ([33b5982](33b5982)) * **core:** NanoTDF resource locator protocol bit mask ([#107](#107)) ([159d2f1](159d2f1)) * crypto API ([#33](#33)) ([b8295b7](b8295b7)) * **lib:** add fallback to namespace kas ([#166](#166)) ([4368840](4368840)) * NanoTDF Implementation ([#46](#46)) ([6485326](6485326)) * **PLAT-3087:** zip reader-writer ([#23](#23)) ([3eeb626](3eeb626)) * SDK Encrypt (with mocked rewrap) ([#45](#45)) ([d67daa2](d67daa2)) * **sdk:** add CLI and integration tests ([#64](#64)) ([df20e6d](df20e6d)) * **sdk:** add mime type. ([#108](#108)) ([6c4a27b](6c4a27b)) * **sdk:** add ssl context ([#58](#58)) ([80246a9](80246a9)) * **sdk:** expose GRPC auth service components ([#92](#92)) ([2595cc5](2595cc5)) * **sdk:** get e2e rewrap working ([#52](#52)) ([fe2c04b](fe2c04b)) * **sdk:** Issue [#60](#60) - expose SDK ([#61](#61)) ([ddef62a](ddef62a)) * **sdk:** provide access tokens dynamically to KAS ([#51](#51)) ([04ca715](04ca715)) * **sdk:** the authorization service is needed for use by gateway ([#85](#85)) ([73cac82](73cac82)) * **sdk:** update archive support ([#47](#47)) ([29a80a9](29a80a9)) * **sdk:** Update the assertion support to match go sdk ([#117](#117)) ([f9badb3](f9badb3)) * support key id in ztdf key access object ([#84](#84)) ([862460a](862460a)) * update README.md ([#142](#142)) ([198d335](198d335)) ### Bug Fixes * Align identifier bytes correctly in ResourceLocator ([#148](#148)) ([2efe226](2efe226)) * **core:** Add support for certs ([#131](#131)) ([2f98a3a](2f98a3a)) * **core:** Revert "feat(core): Add attributes client" ([#124](#124)) ([3d1ef2b](3d1ef2b)) * create TDFs larger than a single segment ([#65](#65)) ([e1da325](e1da325)) * fix pom for release please ([#77](#77)) ([3a3c357](3a3c357)) * Force BC provider use ([#76](#76)) ([1bc9dd9](1bc9dd9)) * get rid of duplicate channel logic ([#59](#59)) ([1edd666](1edd666)) * GitHub packages snapshot repo ([#178](#178)) ([713cb2b](713cb2b)) * GPG key and Maven credentials in release workflow ([#171](#171)) ([864e9ce](864e9ce)) * Issue [#115](#115) - fix for SSL Context for IDP and plaintext platform ([#116](#116)) ([36a29df](36a29df)) * make sure we do not deserialize null ([#97](#97)) ([9579c42](9579c42)) * **nano:** Store key ids if found ([#134](#134)) ([94c672b](94c672b)) * passpharse ([#169](#169)) ([8b3cbed](8b3cbed)) * policy-binding new structure ([#95](#95)) ([b10a61e](b10a61e)) * **sdk:** allow SDK to handle protocols in addresses ([#70](#70)) ([97ae8ee](97ae8ee)) * **sdk:** assertion support in tdf3 ([#82](#82)) ([c299dbd](c299dbd)) * **sdk:** give a test framework test scope ([#90](#90)) ([b99de43](b99de43)) * **sdk:** make sdk auto closeable ([#63](#63)) ([c1bbbb4](c1bbbb4)) * **sdk:** Mixed split fix ([#163](#163)) ([649dac7](649dac7)) * ztdf support both base and handling assertions ([#128](#128)) ([5f72e94](5f72e94)) ### Documentation * **sdk:** Adds brief usage code sample ([#26](#26)) ([79215c7](79215c7)) ### Miscellaneous Chores * release 0.6.1 Release-As: 0.6.1 ([#135](#135)) ([09ec548](09ec548)) * release 0.7.2 ([#184](#184)) ([ea6cf12](ea6cf12)) ### Code Refactoring * move to single jar ([#160](#160)) ([ba9b2d5](ba9b2d5)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NanoTDF will now have the KAS KID set in the KAS ResourceLocator
Resolves #100
Specification: opentdf/spec#40
ADR: opentdf/platform#900