Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service support for TDFs without KAOs is confusing and results in lots of installation pain #1273

Closed
dmihalcik-virtru opened this issue Aug 7, 2024 · 0 comments · Fixed by #1272
Closed

Service support for TDFs without KAOs is confusing and results in lots of installation pain #1273

dmihalcik-virtru opened this issue Aug 7, 2024 · 0 comments · Fixed by #1272

Comments

@dmihalcik-virtru
Copy link
Member

dmihalcik-virtru commented Aug 7, 2024 •
edited
Loading

The current 'keyring' configuration object requires specifying keys twice, once for 'current' keys and again for 'legacy kidless lookup' keys. Since most clients don't yet support key identifiers (e.g. nanoTDF support hasn't been merged (yet?)), this is an optimization without a purpose.

The default KAS behavior should be to look at all keys if the KID is missing. We can later optimize if this becomes a performance issue
@dmihalcik-virtru dmihalcik-virtru mentioned this issue Aug 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 9, 2024
@dmihalcik-virtru
feat(core): Simplifies support for kidless clients (#1272)
dedeb32 
- Changes 'default' behavior of `legacy` field to be true if none are
specified
- This feature is a performance optimization for some imagined future
when all 'new' TDFs are created with KIDs in their KAOs. We are not
there yet.
- Resolves #1273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): Simplifies support for kidless clients opentdf/platform
1 participant
@dmihalcik-virtru