feat(core): KID in NanoTDF KAS ResourceLocator #1190
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'getURL' method has been updated to 'GetURL' in the ResourceLocator struct. Also, a 'GetKasUrl' method has been added to the NanoTDFHeader struct. These updates ensure KID is effectively fetched and used within the code. A Query parameter handling function 'addQueryParamToURL' has also been added to help in adding "kid" parameter to the URL.
Added a debug log to display the kasPublicKey fingerprint. Also, the 'kid' parameter in 'addQueryParamToURL' method is now hardcoded to "e0" instead of using the result of the calculated 'kidHex'.
The error message that is returned when there's an issue with extracting the policy in rewrap.go has been updated to start with a capital letter, ensuring consistency in error message formatting across the codebase.
pflynn-virtru
changed the title
pflynn-virtru
changed the title
The update modifies the function to omit the 'kid' query parameter from all URLs. This parameter was deleted from the queries and then re-encoded. The change prevents potential issues that might arise from passing 'kid' in our requests.
The commit modifies the function to directly retrieve the key identifier (kid) from the KAS public key endpoint instead of computing it inline. This simplifies the process, reduces code redundancy, and makes debugging easier, since now the 'kid' is being fetched directly along with the public key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed format for KAS URL
The 'getURL' method has been updated to 'GetURL' in the ResourceLocator struct. Also, a 'GetKasUrl' method has been added to the NanoTDFHeader struct. These updates ensure KID is effectively fetched and used within the code. A Query parameter handling function 'addQueryParamToURL' has also been added to help in adding "kid" parameter to the URL.
#900
#717
#1203