Feature/nano kid policy key access refactor #1213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new function lookupKidByPublicKey to the Provider in the KAS service, which looks up the key ID based on the provided public key. This function is utilized for key ID lookup in the NanoTDF rewrap method instead of the previous method. Also, included the PublicKeyBytes in the NanoTDF struct and other relevant areas. Moreover, created GetECCompressedKeyLengthFromECCMode in the EC Key Pair to extract the length of the compressed key given an ECC mode. The new approach allows us to associate public keys with their respective key IDs more efficiently.
The update implements ECDSA support for policy keys in NanoTDF configuration. A new function ECPubKeyFromPemECDSA was added to generate an ECDSA public key from a PEM format. This also introduces changes in the nanotdf_config.go where the Policy key is now recognized as the KAS Key. Additional error handling has also been put into place in nanotdf.go for any errors during the process.
Replaced string types with dedicated KID and Algorithm types across various functions and structs. This change enhances type safety and consistency in handling cryptographic keys and algorithms. It also includes updates to related test cases and error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.