-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Allow for payload key retrieval. #1230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ryan Schumacher <jschumacher@virtru.com>
Co-authored-by: Ryan Schumacher <jschumacher@virtru.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
strantalis
approved these changes
Aug 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.5](sdk/v0.3.4...sdk/v0.3.5) (2024-08-12) ### Features * Adds IsValidTDF function - needs tests ([#1188](#1188)) ([4750195](4750195)) * **sdk:** add assertion to tdf3 ([#575](#575)) ([5bbce71](5bbce71)) * **sdk:** Allow for payload key retrieval. ([#1230](#1230)) ([c3423fc](c3423fc)) ### Bug Fixes * **core:** Autobump sdk ([#1313](#1313)) ([0eda439](0eda439)) * **kas:** Regenerate protos and fix tests from info rpc removal ([#1291](#1291)) ([91a2fe6](91a2fe6)) * **sdk:** Allow hyphens in attr namespaces ([#1250](#1250)) ([a034bd5](a034bd5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1310
Note
If the NPE already has access to do the unwrap, then add a method to allow NPEs to retrieve the key.
This is helpful for use cases where the encryption/decryption is not done by Virtru, but by a 3rd party.
In such as case, Virtru is acting as an external key manager, and the key needs to be provided to the
party doing the enc/decr.