chore(ci): Remove keytool step #1276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmihalcik-virtru
commented
Aug 7, 2024
•
dmihalcik-virtru
commented
- instead of a JKS encrypted with 'password', just store self-signed CA as a plain text pkcs12 file
- Closes keycloak fixture: Replace JKS with PKCS12 #1484
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@imdominicreed I think this should do what the previous step was doing but IDK how to validate it - do we have automated tests in this repo that verify that the self signed cert is respected? |
dmihalcik-virtru
force-pushed
the
feature/pkcs12-truststore
branch
from
6fbf18a
to
de09e22
Compare
|
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
- instead of a JKS encrypted with 'password', just store self-signed CA as a plain text pkcs12 file
dmihalcik-virtru
force-pushed
the
feature/pkcs12-truststore
branch
from
d69aae8
to
0aa7b33
Compare
dmihalcik-virtru
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.