Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(policy): make MatchSubjectMappings operator agnostic #1658

Merged
merged 28 commits into from
Nov 4, 2024

Conversation

suchak1
Copy link
Contributor

@suchak1 suchak1 commented Oct 16, 2024

resolves: #1499

@suchak1 suchak1 changed the title fix(policy): make MatchSubjectMappings operator agnostic fix(policy): DSP-54 make MatchSubjectMappings operator agnostic Oct 16, 2024
@suchak1 suchak1 marked this pull request as ready for review October 21, 2024 20:47
@suchak1 suchak1 requested a review from a team as a code owner October 21, 2024 20:47
jakedoublev
jakedoublev previously approved these changes Oct 22, 2024
service/policy/db/query.sql Outdated Show resolved Hide resolved
service/policy/db/subject_mappings.go Show resolved Hide resolved
1. removes metadata from query
2. ensures integration tests accurately test same JSONB stored by policy
create/update APIs instead of fixtures (which differ in casing as
`snake_case` instead of `camelCase` when marshaled by `protojson`)
3. ensures value field is not required on `SubjectProperty` message
which is not needed by this API
@jakedoublev jakedoublev requested review from a team as code owners November 4, 2024 18:30
@jakedoublev jakedoublev enabled auto-merge November 4, 2024 18:31
jakedoublev
jakedoublev previously approved these changes Nov 4, 2024
@jakedoublev jakedoublev added this pull request to the merge queue Nov 4, 2024
@jakedoublev jakedoublev removed this pull request from the merge queue due to a manual request Nov 4, 2024
1. merge with `main` latest
2. `make proto-generate` to build latest gencode from protos to handle
the merge conflict in `protocol/go/policy/objects.pb.go`
@jakedoublev jakedoublev changed the title fix(policy): DSP-54 make MatchSubjectMappings operator agnostic fix(policy): make MatchSubjectMappings operator agnostic Nov 4, 2024
@jakedoublev jakedoublev enabled auto-merge November 4, 2024 21:16
@jakedoublev jakedoublev added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit cb63819 Nov 4, 2024
22 checks passed
@jakedoublev jakedoublev deleted the feature/matchsubjectmappings branch November 4, 2024 21:29
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.2.19](protocol/go/v0.2.18...protocol/go/v0.2.19)
(2024-11-05)


### Features

* **policy:** 1651 move GetAttributesByValueFqns RPC request validation
to protovalidate
([#1657](#1657))
([c7d6b15](c7d6b15))
* **policy:** add optional name field to registered KASes in policy
([#1636](#1636))
([f1382c1](f1382c1))
* **policy:** limit/offset throughout LIST protos/gencode
([#1668](#1668))
([7de6cce](7de6cce))
* **policy:** subject condition sets prune protos/gencode
([#1687](#1687))
([a627e02](a627e02))


### Bug Fixes

* **policy:** enhance proto validation across policy requests
([#1656](#1656))
([df534c4](df534c4))
* **policy:** make MatchSubjectMappings operator agnostic
([#1658](#1658))
([cb63819](cb63819))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.4.27](service/v0.4.26...service/v0.4.27)
(2024-11-14)


### Features

* **authz:** JWT ERS that just returns claims
([#1630](#1630))
([316b5be](316b5be))
* **authz:** Remove org-admin role, move privileges to admin role
([#1740](#1740))
([ae931d0](ae931d0))
* backend migration to connect-rpc
([#1733](#1733))
([d10ba3c](d10ba3c))
* connectrpc realip interceptor
([#1728](#1728))
([292fca0](292fca0))
* **docs:** add policy ADR for LIST limit and pagination
([#1557](#1557))
([069f939](069f939))
* move from fasthttp in-memory listener to memhttp implementation
([#1709](#1709))
([70518ff](70518ff))
* **policy:** 1603 policy improve upsertattrfqn
([#1679](#1679))
([cd17a44](cd17a44))
* **policy:** 1651 move GetAttributesByValueFqns RPC request validation
to protovalidate
([#1657](#1657))
([c7d6b15](c7d6b15))
* **policy:** 1659 spike on transactions support
([#1678](#1678))
([a6fea11](a6fea11))
* **policy:** add optional name field to registered KASes in policy
([#1636](#1636))
([f1382c1](f1382c1))
* **policy:** add optional name field to registered KASes in policy
([#1641](#1641))
([b277ab4](b277ab4))
* **policy:** limit/offset throughout LIST protos/gencode
([#1668](#1668))
([7de6cce](7de6cce))
* **policy:** SPIKE transactions support
([#1663](#1663))
([866f4f3](866f4f3))
* **policy:** subject condition sets prune protos/gencode
([#1687](#1687))
([a627e02](a627e02))
* **policy:** subject condition sets prune service/db
([#1688](#1688))
([3cdd1b2](3cdd1b2)),
closes [#1178](#1178)
* update service registry in preperation for connectrpc migration
([#1715](#1715))
([ce289a4](ce289a4))


### Bug Fixes

* cleanup left over status.Error in favor of connect.NewError
([#1751](#1751))
([acea8d1](acea8d1))
* **core:** Autobump service
([#1726](#1726))
([39a898d](39a898d))
* **core:** Autobump service
([#1739](#1739))
([46662a7](46662a7))
* **core:** Autobump service
([#1750](#1750))
([4b239b1](4b239b1))
* Fixtures CodeQL alert for potentially unsafe quoting
([#1703](#1703))
([6f2fa9b](6f2fa9b))
* **kas:** Only hit authorization if data attributes not empty
([#1741](#1741))
([471f5f1](471f5f1))
* **policy:** enhance proto validation across policy requests
([#1656](#1656))
([df534c4](df534c4))
* **policy:** make MatchSubjectMappings operator agnostic
([#1658](#1658))
([cb63819](cb63819))
* **policy:** REVERT PR
[#1663](#1663) - SPIKE
transactions support
([#1719](#1719))
([184a733](184a733))
* **policy:** schema markdown links should work
([#1672](#1672))
([4122262](4122262))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
jakedoublev added a commit to opentdf/otdfctl that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy: MatchSubjectMappings should be operator agnostic
2 participants