Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): GetDecisions should handle empty string and non-existent attributes #1832

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(core): GetDecisions should handle empty string and non-existent attributes #1832

wants to merge 3 commits into from

Conversation

elizabethhealy
Copy link
Member

Proposed Changes

  • if a resouce attribute fqn list only has "", DENY
  • if a resource attribute fqn list has "" and other attributes, ignore the ""
  • if a resource attribute fqn list has a non existent attribute, DENY

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@elizabethhealy elizabethhealy marked this pull request as ready for review December 20, 2024 20:19
@elizabethhealy elizabethhealy requested a review from a team as a code owner December 20, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizabethhealy @pflynn-virtru