Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Require node 18 for node users #101

Merged
merged 17 commits into from
Oct 28, 2022
Merged

⬆️ Require node 18 for node users #101

merged 17 commits into from
Oct 28, 2022

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Oct 26, 2022 •
edited
Loading

  • Node 18 includes a global 'fetch' command, removing the need to include node-fetch
  • Notably, node-fetch fails when run from a CommonJS require block now, so this also adds a commonJS node test to prevent any regression on loading @opentdf/client in a node app that uses CJS

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review October 27, 2022 20:20
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner October 27, 2022 20:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pflynn-virtru
pflynn-virtru approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@pflynn-virtru pflynn-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are adding more test directories, perhaps we should move them under tests directory.

@dmihalcik-virtru dmihalcik-virtru merged commit 2332a94 into opentdf:main Oct 28, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/to-18 branch October 28, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmihalcik-virtru @pflynn-virtru