Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Remove need to readable stream aliases #102

Merged
merged 8 commits into from
Nov 10, 2022
Merged

🔥 Remove need to readable stream aliases #102

merged 8 commits into from
Nov 10, 2022

Conversation

dmihalcik-virtru
Copy link
Member

  • WebStreams are supported in node 16.5+, so require those as needed.
  • Translate a few remaining uses of non-web streams into web streams
  • Remove aliases

@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review November 1, 2022 23:54
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner November 1, 2022 23:54
@dmihalcik-virtru
Copy link
Member Author

@danielRicaud Do you know what the @runtimeConfig alias is/was used for?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmihalcik-virtru dmihalcik-virtru merged commit 10fbd2f into opentdf:main Nov 10, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/no-aliases branch November 10, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

@ivanovSPvirtru ivanovSPvirtru Awaiting requested review from ivanovSPvirtru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmihalcik-virtru @pflynn-virtru