Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Let attributes have capital letters and dashes #103

Merged
merged 6 commits into from
Nov 2, 2022
Merged

🐛 Let attributes have capital letters and dashes #103

merged 6 commits into from
Nov 2, 2022

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Nov 2, 2022 •
edited
Loading

  • Fix attribute regex to match KAS attribute regex
  • Update test to not continue to succeed after first test succeeds by varying the input and being a little bit better (but not great) about cleaning up after

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmihalcik-virtru dmihalcik-virtru changed the title 🚧 investigating errors 🐛 Let attributes have capital letters and dashes Nov 2, 2022
@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review November 2, 2022 19:01
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner November 2, 2022 19:01
@dmihalcik-virtru dmihalcik-virtru merged commit 1151cdf into opentdf:main Nov 2, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/fail-faster branch November 2, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabethhealy elizabethhealy elizabethhealy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmihalcik-virtru @elizabethhealy