Locker complience fixed #131
Conversation
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
| @@ -136,7 +137,6 @@ export class AccessToken { | |||
| } | |||
| if (this.signing_key) { | |||
| // TODO: dpop does not have a CommonJS variant. | |||
| const { default: dpopFn } = await import('dpop'); | |||
There was a problem hiding this comment.
I think this is to work around the dpop library not exporting a CJS variant. Node supports dynamic import even in CJS so we may have to do something else here - or fork the library, most likely
There was a problem hiding this comment.
Damn it. Welp, last time i had such issues with locker complience, ive just putted lib as a folder. Not whole thing but what we use. Also we could fork it and add webpack to bundle CJS variant. Or maybe theres other libs that doing what drop does
There was a problem hiding this comment.
I'm thinking we can fork as opentdf and publish to GitHub's package registry. Adding the CommonJS output should be pretty similar to what we are doing with this library now
Signed-off-by: sivanov <sivanov.ctr@virtru.com>
ivanovSPvirtru
force-pushed
the
feature/locker-complience-fixed
branch
from
e69c4df to
7c87dc2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
* Locker complience fixed * 🤖 🎨 Autoformat Signed-off-by: sivanov <sivanov.ctr@virtru.com> * CJS removed * Readme change Signed-off-by: sivanov <sivanov.ctr@virtru.com> Co-authored-by: ivanovSPvirtru <ivanovSPvirtru@users.noreply.github.com>
* Locker complience fixed * 🤖 🎨 Autoformat Signed-off-by: sivanov <sivanov.ctr@virtru.com> * CJS removed * Readme change Signed-off-by: sivanov <sivanov.ctr@virtru.com> Co-authored-by: ivanovSPvirtru <ivanovSPvirtru@users.noreply.github.com>
Locker api also doesn't like dynamic import