Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Consolidate and clean up base64 code #135

Merged
merged 4 commits into from
Jan 26, 2023
Merged

🎨 Consolidate and clean up base64 code #135

merged 4 commits into from
Jan 26, 2023

Conversation

dmihalcik-virtru
Copy link
Member

  • prefer lookup table to indexof generally; this should be faster but I haven't bothered with a check. lmk if you want some numbers
  • standardize error conditions between arraybuffer and string variants so they throw (or don't) in the same conditions
  • gets to 100% coverage in the unit test
  • Adds support for url safe encodings

@dmihalcik-virtru
🎨 Consolidate and clean up base64 code
8fe478d 
- prefer lookup table to indexof generally; this should be faster but I haven't bothered with a check. lmk if you want some numbers
- standardize error conditions between arraybuffer and string variants so they throw (or don't) in the same conditions
- get to 100% coverage in the unit test
- Add support for url safe encodings
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner January 20, 2023 14:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmihalcik-virtru dmihalcik-virtru merged commit c2445a6 into opentdf:main Jan 26, 2023
@dmihalcik-virtru dmihalcik-virtru deleted the feature/base64-better branch January 26, 2023 14:29
danielRicaud pushed a commit that referenced this pull request Feb 1, 2023
@dmihalcik-virtru @danielRicaud
🎨 Consolidate and clean up base64 code (#135)
834158e 
- Adds support for url safe encodings
- gets to 100% coverage in the unit test
- prefers lookup table to indexof generally; this should be faster but I haven't bothered to write a jsperf check
- standardize error conditions between arraybuffer and string variants so they throw (or don't) in the same conditions
danielRicaud pushed a commit that referenced this pull request Feb 1, 2023
@dmihalcik-virtru @danielRicaud
🎨 Consolidate and clean up base64 code (#135)
47194a0 
- Adds support for url safe encodings
- gets to 100% coverage in the unit test
- prefers lookup table to indexof generally; this should be faster but I haven't bothered to write a jsperf check
- standardize error conditions between arraybuffer and string variants so they throw (or don't) in the same conditions
danielRicaud pushed a commit that referenced this pull request Feb 1, 2023
@dmihalcik-virtru @danielRicaud
🎨 Consolidate and clean up base64 code (#135)
207488a 
- Adds support for url safe encodings
- gets to 100% coverage in the unit test
- prefers lookup table to indexof generally; this should be faster but I haven't bothered to write a jsperf check
- standardize error conditions between arraybuffer and string variants so they throw (or don't) in the same conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmihalcik-virtru @pflynn-virtru