Added rca support #148
Merged
Added rca support #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient-web into feature/rca-link-service-aws-2
…-link-service-aws-2
package.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Delete these stray package and package-lock files from the project root
| @@ -33,7 +33,7 @@ export abstract class DecoratedReadableStream { | |||
| upsertResponse?: UpsertResponse; | |||
|
|
|||
| constructor(byteLimit: number, underlyingSource: UnderlyingSource) { | |||
There was a problem hiding this comment.
If we don't allow byteLimit to be set anymore should we go through and remove it entirely?
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
Signed-off-by: Daniel Ricaud <dricaud@virtru.com>
danielRicaud
force-pushed
the
feature/rca-link-service-aws-2
branch
from
7c86681 to
f213c4e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dmihalcik-virtru
approved these changes
Feb 14, 2023
| constructor(byteLimit: number, underlyingSource: UnderlyingSource) { | ||
| this.stream = new ReadableStream(underlyingSource, { highWaterMark: byteLimit }); | ||
| constructor(underlyingSource: UnderlyingSource) { | ||
| this.stream = new ReadableStream(underlyingSource, { highWaterMark: 1 }); |
There was a problem hiding this comment.
IIUC this will always immediately write whatever to the underlying stream. Which makes sense, as this is just supposed to be a proxy, not a buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-link-service-aws-2