Changes streamsavers service worker, and fixes vscode TS error #176
Conversation
lib/.eslintrc.yaml
Outdated
There was a problem hiding this comment.
Fixes the following VScode error, has anyone else seen this at the top of .ts files in client-web?
| @@ -22,6 +22,8 @@ export class BrowserTdfStream extends DecoratedReadableStream { | |||
| return; | |||
| } | |||
|
|
|||
| streamSaver.mitm = 'https://secure.virtru.com/rca/stream-saver/index.html'; | |||
There was a problem hiding this comment.
Any place we can un-hardcode this and make it dynamic per environment? Although Auth-Widget is hardcoded to prod so maybe this isn't a deal breaker?
There was a problem hiding this comment.
My suggestion: Delete this method and just do it manually. We can move the code over to web-app as sample code, and implement it in virtru-sdk if we really need it
There was a problem hiding this comment.
no Virtru urls in OpenTDF
There was a problem hiding this comment.
Any opinions on where this should live? Since stream-saver is only utilized in client-web?
…ate-stream-saver-service-worker-url
|
Kudos, SonarCloud Quality Gate passed!
|
This PR should not be merged until the following PR has been promoted to prod (currently in staging): https://github.com/virtru-corp/zzz-secure-virtru-com/commit/370beb79875a42665ec461e59cd11467d19d6cbb
This PR changes which mitm.html (man in the middle) and service worker StreamSaver references over to one Virtru is hosting themselves rather then relying on the library creator to host mitm.html and service worker. This protects us from any upstream library changes in StreamSaver.