Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-2492 Optimised download process #188

Merged
merged 16 commits into from
May 25, 2023
Merged

PLAT-2492 Optimised download process #188

merged 16 commits into from
May 25, 2023

Conversation

ivanovSPvirtru
Copy link
Contributor

No description provided.

@ivanovSPvirtru ivanovSPvirtru requested a review from a team as a code owner May 24, 2023 12:47
@github-actions
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@ivanovSPvirtru ivanovSPvirtru force-pushed the feature/PLAT-2492 branch 2 times, most recently from cb70ada to 78ab76e Compare May 24, 2023 14:59
danielRicaud
danielRicaud reviewed May 24, 2023
View reviewed changes
lib/tdf3/src/tdf.ts Outdated
reconstructedKeyBinary: Binary
) {
const requestsInParallelCount = 100;
let requsets = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests* 😎

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivanovSPvirtru ivanovSPvirtru merged commit ac487b8 into main May 25, 2023
@ivanovSPvirtru ivanovSPvirtru deleted the feature/PLAT-2492 branch May 25, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielRicaud danielRicaud danielRicaud left review comments

@krokhmaliuk-virtru krokhmaliuk-virtru krokhmaliuk-virtru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanovSPvirtru @danielRicaud @krokhmaliuk-virtru