Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): adds --assertions option #370

Closed

Conversation

dmihalcik-virtru
Copy link
Member

No description provided.

Update assertion.ts

fix(lib): Removes all refs to node:buffer I could find

- removes the polyfill from the web-test-runner, to make sure we aren't accidentally including it (at least in things that covers)
- updates all .spec and .test files, in turn
- renames a bunch of things called `buffer` to something else so I can search for this easier

Update cli.ts
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner October 28, 2024 16:04
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@dmihalcik-virtru
Copy link
Member Author

merged with #371

@dmihalcik-virtru dmihalcik-virtru deleted the feature/assertion-flag-fewer-other-changes branch November 18, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant