Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove environment logging in vite.config.ts #373

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jentfoo
Copy link
Contributor

@jentfoo jentfoo commented Nov 4, 2024

The environment may contain sensitive secrets. For this reason we should avoid logging it to the console. This was identified by CodeQL here: https://github.com/opentdf/web-sdk/security/code-scanning/3

The environment may contain sensitive secrets.  For this reason we should avoid logging it to the console.
@jentfoo jentfoo self-assigned this Nov 4, 2024
@jentfoo jentfoo requested a review from a team as a code owner November 4, 2024 22:52
Copy link

sonarqubecloud bot commented Nov 4, 2024

@jentfoo jentfoo merged commit d1e0a45 into main Nov 5, 2024
12 checks passed
@jentfoo jentfoo deleted the jent/remove_env_logging branch November 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants