✅ round trip test, less rewrap #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmihalcik-virtru
commented
Apr 26, 2022
•
dmihalcik-virtru
commented
- Adds a round-trip test for nanotdf encrypt/decrypt
- like the 'roundtrip' tests in tdf3-js, this mocks out the entirety of the key rewrap mechanism, which is arguably the harder bit
- removes the unused unwrappedKey field. Really, we need to do an audit to make this more functional overall and less state-preserving
- Adds back source maps for better error reports.
- We should build on top of this somehow to add more coverage of unusual situations
|
Comparison of coverage numbers: After: |
|
I'm guessing line coverage went down since I turned on source maps, which probably could include a bunch of typescript declarations? |
dmihalcik-virtru
force-pushed
the
feature/complete-test
branch
from
fd3cee7 to
e913904
Compare
ysizarie-virtru
previously approved these changes
May 3, 2022
danielRicaud
previously approved these changes
May 3, 2022
- like the 'roundtrip' tests in tdf3-js, this mocks out the entirety of the key rewrap mechanism, which is arguably the harder bit - removes the unused unwrappedKey field. Really, we need to do an audit to make this more functional overall and less state-preserving
dmihalcik-virtru
dismissed stale reviews from danielRicaud and ysizarie-virtru
via
cdb5856
dmihalcik-virtru
force-pushed
the
feature/complete-test
branch
from
e913904 to
cdb5856
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
danielRicaud
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.