🏷 typescript enhancements #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmihalcik-virtru
commented
May 19, 2022
dmihalcik-virtru
commented
- More return types
- fewer ts-ignores
- some more types!
- More return types - fewer ts-ignores - some more types!
|
SonarCloud Quality Gate failed.
|
| @@ -25,5 +25,5 @@ | |||
| "strictPropertyInitialization": true, | |||
| "target": "ES2017" | |||
| }, | |||
| "include": ["src", "test"] | |||
| "include": ["facade", "src", "test", "tdf3"] | |||
There was a problem hiding this comment.
it would be nice to remove test from bundle
There was a problem hiding this comment.
This is for running tsc. Bundling is accomplished with web pack.config, which I think doesn't include these? (It gives an entry point, and then tests/etc should be shaken out), or the package.json files directive, which removes them from the esm module that is the only thing that seems to be built.
pflynn-virtru
approved these changes
May 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.