🔥 Remove 'keycloak realm' as param #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I did this but was never terribly happy with it. All OIDC providers/IdPs (Okta, etc) that are multitenant (that is, all of them) will have a similar construct (org, realm, etc) - but yeah I see no real reason why we can't just make it part of the URL. |
pflynn-virtru
previously approved these changes
Jul 20, 2022
dmihalcik-virtru
dismissed stale reviews from pflynn-virtru and bleggett
via
64fdacc
dmihalcik-virtru
force-pushed
the
feature/decloaked
branch
from
64fdacc to
f1c3890
Compare
dmihalcik-virtru
force-pushed
the
feature/decloaked
branch
from
79087b3 to
4090cb4
Compare
dmihalcik-virtru
force-pushed
the
feature/decloaked
branch
from
3c9fb49 to
16dd0dc
Compare
- Previously, we explicitly required passing in 'realm', variously referred to as `orgName` or `organizationName`, which we then used to build a keycloak-style URL - This is not part of the OIDC spec and a keycloak addition to support multi-tenancy. This is evident in how all realm requests are based off the `[root]/realms[realm]` path, including the `.well-known` OIDC discovery paths. - Instead, explicitly include the path as part of the root OIDC url - While I'm here, remove a few explicit references to keycloak
dmihalcik-virtru
force-pushed
the
feature/decloaked
branch
from
16dd0dc to
50fdd58
Compare
This gets rid of the 'unsupported version of typescript' error, as this version supports ts 4.8
|
Kudos, SonarCloud Quality Gate passed!
|
pflynn-virtru
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orgNameororganizationName, which we then used to build a keycloak-style URL[root]/realms[realm]path, including the.well-knownOIDC discovery paths.