Fixed crypto import and isNodeStream function #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanovSPvirtru
commented
Aug 25, 2022
| @@ -14,7 +14,8 @@ interface FileClientConfig { | |||
| } | |||
|
|
|||
| function isNodeStream(source: InputSource): source is NodeJS.ReadableStream { | |||
| return Object.prototype.hasOwnProperty.call(source, 'pipe'); | |||
There was a problem hiding this comment.
amazingly hasOwnProperty returns false for stream altough !!source.pipe returns pipe. HasOwnPropery is for innumerable props (the one that will appear in loop, native methods are not innumerable).
mustyantsev
previously approved these changes
Aug 25, 2022
dmihalcik-virtru
requested changes
Aug 25, 2022
lib/facade/FileClient.ts
Outdated
Comment on lines
17
to
18
| // @ts-ignore | ||
| return typeof source?.pipe === 'function'; |
There was a problem hiding this comment.
Suggested change
| // @ts-ignore | |
| return typeof source?.pipe === 'function'; | |
| return typeof (source as NodeJS.ReadableStream)?.pipe === 'function'; |
|
Kudos, SonarCloud Quality Gate passed!
|
dmihalcik-virtru
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.