Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 CI workflow improvements #83

Merged

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Aug 30, 2022

  • Move format out to its own workflow since it is all by itself anyway and kinda different
  • improve error messaging
  • Don't re-install npm in the retry loop; only do that once

@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner August 30, 2022 19:22
mustyantsev
mustyantsev previously approved these changes Aug 31, 2022
- Move format out to its own workflow since it is all by itself anyway and kinda different
- improve error messaging
- Don't re-install npm in the retry loop; only do that once
-
pflynn-virtru
pflynn-virtru previously approved these changes Aug 31, 2022
@dmihalcik-virtru
Copy link
Member Author

merge conflict :/ (multiple timeouts were added to a job)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmihalcik-virtru dmihalcik-virtru merged commit 08b836e into opentdf:main Aug 31, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/workflow-improvements branch August 31, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants