Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix exports in @opentdf/client #87

Merged
merged 8 commits into from
Sep 5, 2022

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Sep 2, 2022

  • We were not including tdf3 in some of our bundles
  • Most notably, node was failing to work with ESM in tdf3 mode.
  • So I've added a --containerType tdf3 option to the cli tool and code to test it
  • We somehow dropped the commonjs annotation package.jsons
  • Update the entry point names to get rid of the nano-node-esm option, instead making it inferrable using orthogonal nested conditions. Now we just export two entry points, the normal package (everything) and the nano/dataset only
  • Removes node-forge's x509 parsing in favor of a similar method in jose (node-forge is CommonJS, and Jose is ESM)
  • Fixes type annotation exports, and related fixes to cli.ts after those were re-enabled

obidenko
obidenko previously approved these changes Sep 2, 2022
Ideally we'd get this all over to src soon, and expose tree-shakable endpoints, too
node-fetch was required when we had to do polyfills manually. now they are handled by the library
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivanovSPvirtru ivanovSPvirtru merged commit 554aa05 into opentdf:main Sep 5, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/fix-exports branch September 7, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants