Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧼 Some small cleanups #97

Merged
merged 2 commits into from
Oct 3, 2022
Merged

🧼 Some small cleanups #97

merged 2 commits into from
Oct 3, 2022

Conversation

dmihalcik-virtru
Copy link
Member

  • Remove a ts-ignore or two
  • Remove unused reference to node-forge
  • remove some logs

@dmihalcik-virtru
🧼 A variety of little cleanups
0f03062
@dmihalcik-virtru
Adds types to byteLength
328eeb8 
it looks like the types indicate the lstat code is unused.
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner September 30, 2022 21:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmihalcik-virtru
Copy link
Member Author

@ivanovSPvirtru This is code I think you added to add compatibility with file streams? It looks like the lstat path is dead code or at least that is what the static types indicate

@dmihalcik-virtru dmihalcik-virtru merged commit 53ad0f6 into opentdf:main Oct 3, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/cleanups branch October 3, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabethhealy elizabethhealy elizabethhealy approved these changes

@ivanovSPvirtru ivanovSPvirtru Awaiting requested review from ivanovSPvirtru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmihalcik-virtru @elizabethhealy