Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex create #74

Merged
merged 24 commits into from
Nov 22, 2021
Merged

Complex create #74

merged 24 commits into from
Nov 22, 2021

Conversation

Polina-Gubina
Copy link
Contributor

No description provided.

# Conflicts:
#	octavia_proxy/tests/functional/api/v2/test_listener.py
#	octavia_proxy/tests/functional/api/v2/test_pool.py
@Polina-Gubina Polina-Gubina force-pushed the complex-create branch 4 times, most recently from 109b681 to 41c6201 Compare October 6, 2021 08:02
@Polina-Gubina Polina-Gubina force-pushed the complex-create branch 3 times, most recently from 6fd3f12 to a668ee9 Compare October 7, 2021 11:51
otc-zuul[bot]
otc-zuul bot previously approved these changes Oct 11, 2021
otc-zuul[bot]
otc-zuul bot previously approved these changes Oct 19, 2021
@Polina-Gubina Polina-Gubina force-pushed the complex-create branch 2 times, most recently from 59fba0a to 243d60d Compare October 20, 2021 15:16
otc-zuul[bot]
otc-zuul bot previously approved these changes Oct 20, 2021
otc-zuul[bot]
otc-zuul bot previously approved these changes Oct 25, 2021
otc-zuul[bot]
otc-zuul bot previously approved these changes Oct 25, 2021
@Polina-Gubina Polina-Gubina marked this pull request as ready for review October 25, 2021 09:57
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 3, 2021
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 3, 2021
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 3, 2021
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 3, 2021
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 3, 2021
@Polina-Gubina
Copy link
Contributor Author

This is such a complex case that we can not proceed without any tests. At least integration if this is hard to cover in units

done

i don't see here cascade delete on failure, please add this

done

Copy link
Member

@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are improvements required, but we should not try to squeeze them here.

@gtema gtema added the gate Merge PR label Nov 16, 2021
@otc-zuul
Copy link

otc-zuul bot commented Nov 22, 2021

Build succeeded.

✔️ otc-tox-docs SUCCESS in 3m 39s
✔️ otc-tox-pep8 SUCCESS in 2m 54s
✔️ otc-tox-py39-tips SUCCESS in 4m 40s
✔️ octavia-proxy-upload-image SUCCESS in 5m 18s
✔️ tox-functional SUCCESS in 5m 46s

@otc-zuul otc-zuul bot merged commit 5efb61f into main Nov 22, 2021
@otc-zuul otc-zuul bot deleted the complex-create branch November 22, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants