Pagination #94
Pagination #94
Conversation
…y into pagination � Conflicts: � octavia_proxy/api/v2/controllers/load_balancer.py
![otc-zuul[bot]](https://avatars.githubusercontent.com/in/11628?s=60&v=4){kind=small}
irina-pereiaslavskaia
requested review from
kucerakk,
lego963,
outcatcher,
SebastianGode and
tischrei
| @@ -90,7 +92,7 @@ def from_data_model(cls, data_model, children=False): | |||
| listener_model(id=i['id']) for i in listeners] | |||
| result.pools = [ | |||
| pool_model(id=i['id']) for i in pools] | |||
| result.admin_state_up = data_model.is_admin_state_up | |||
| # result.admin_state_up = data_model.is_admin_state_up | |||
octavia_proxy/api/v2/types/pool.py
Outdated
| @@ -90,36 +93,55 @@ class PoolResponse(BasePoolType): | |||
|
|
|||
| @classmethod | |||
| def from_data_model(cls, data_model, children=False): | |||
| LOG.debug('DATA_MODEL {}'.format(data_model)) | |||
There was a problem hiding this comment.
Remove logs
| # query_params = pagination_helper.params | ||
| # query_filter.update(query_params) |
There was a problem hiding this comment.
query_filter used in driver_invocation, need to think how to pass query params\filter to driver with excluded pagination params
There was a problem hiding this comment.
I will try to do this in another PR.
| # query_params = pagination_helper.params | ||
| # query_filter.update(query_params) |
There was a problem hiding this comment.
I will try to do this in another PR.
| # query_params = pagination_helper.params | ||
| # TODO: fix filtering and sorting, especially for multiple providers | ||
| query_filter.update(query_params) | ||
| # query_filter.update(query_params) |
There was a problem hiding this comment.
I will try to do this in another PR.
|
|
||
| # TODO: fix filtering and sorting, especially for multiple providers | ||
| if 'vip_port_id' in query_params: | ||
| query_filter['vip_port_id'] = query_params['vip_port_id'] | ||
| query_filter.update(query_params) | ||
| # query_filter.update(query_params) |
There was a problem hiding this comment.
I will try to do this in another PR.
| # query_params = pagination_helper.params | ||
| # query_filter.update(query_params) |
There was a problem hiding this comment.
I will try to do this in another PR.
| # query_params = pagination_helper.params | ||
| # query_filter.update(query_params) |
There was a problem hiding this comment.
I will try to do this in another PR.
| # query_params = pagination_helper.params | ||
| # query_filter.update(query_params) |
There was a problem hiding this comment.
I will try to do this in another PR.
irina-pereiaslavskaia
dismissed stale reviews from Polina-Gubina and otc-zuul[bot]
via
9ae3d67
|
let's merge |
irina-pereiaslavskaia
requested review from
Polina-Gubina and
anton-sidelnikov
|
Build succeeded. ✔️ otc-tox-docs SUCCESS in 3m 39s |
Add pagination logic to controllers and unit tests for it.