Merge pull request open-telemetry#137 from MSNev/MSNev/AddComponents

fix: Fixup repo merging with a submodule (./protos)
opentelemetrybot · Jul 11, 2023 · cfa232e · cfa232e
2 parents f342aea + 2d25286
commit cfa232e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 12 deletions.
diff --git a/sandbox-tools/merge-repos/src/git/resolveConflictsToTheirs.ts b/sandbox-tools/merge-repos/src/git/resolveConflictsToTheirs.ts
@@ -131,10 +131,19 @@ function getFileStatus(status: StatusResult, name: string): FileStatusResult {
                     conflicted
                 ]);
 
-                await git.raw([
-                    "add",
-                    "-f",
-                    conflicted]);
+                try {
+                    await git.raw([
+                        "add",
+                        "-f",
+                        conflicted]);
+                } catch (e) {
+                    if (!conflicted.endsWith("/protos")) {
+                        throw e;
+                    } else {
+                        log(` - !! Ignoring git add for known submodule folder - ${conflicted}`);
+                        await git.rm(conflicted);
+                    }
+                }
             } else {
                 commitMessage = logAppendMessage(gitRoot, commitMessage, fileStatus, `Removed from ${fileStatus.working_dir === "D" ? "both" : "theirs"}`);
                 await git.rm(conflicted);

diff --git a/sandbox-tools/merge-repos/src/support/mergeFixup.ts b/sandbox-tools/merge-repos/src/support/mergeFixup.ts
@@ -127,14 +127,17 @@ export async function checkFixBadMerges(
             let destStats = fs.statSync(destFolder + "/" + destFile);
             if (destStats.isDirectory()) {
                 commitDetails.message = logAppendMessage(mergeGitRoot, commitDetails.message, { index: "*", working_dir: "F", path: destFolder + "/" + destFile } , `Removing extra folder ${destFile}`);
-                await git.raw([
-                    "rm",
-                    "-f",
-                    "-r",
-                    destFolder + "/" + destFile]);
-                // fs.rmdirSync(destFolder + "/" + destFile, {
-                //     recursive: true
-                // });
+                try {
+                    await git.raw([
+                        "rm",
+                        "-f",
+                        "-r",
+                        destFolder + "/" + destFile]);
+                } catch (e) {
+                    fs.rmdirSync(destFolder + "/" + destFile, {
+                        recursive: true
+                    });
+                }
             } else {
                 commitDetails.message = logAppendMessage(mergeGitRoot, commitDetails.message, { index: "*", working_dir: "E", path: destFolder + "/" + destFile } , "Removing extra file");
                 await git.rm(destFolder + "/" + destFile);