add neuron certificate handling #750
Conversation
andreea-popescu-reef
force-pushed
the
encrypt
branch
2 times, most recently
from
88eff8c
to
ae34fd5
Compare
|
On seconds thoughts, adding the new extrinsic ensures backwards compatibility , so a bit undecided here |
pallets/subtensor/src/lib.rs
Outdated
| #[derive(Decode, Encode, Default, TypeInfo, PartialEq, Eq, Clone, Debug)] | ||
| pub struct NeuronCertificate { | ||
| /// The neuron certificate. | ||
| pub certificate: Vec<u8>, |
There was a problem hiding this comment.
Can we make it a bounded vector instead? There should be a limit of how much data can an axon store on-chain.
There was a problem hiding this comment.
It is better to add freeze_struct, even for this simple struct.
There was a problem hiding this comment.
will add freeze_struct
There was a problem hiding this comment.
@andreea-popescu-reef what about the using a bounded vec ? Have you tested with actual certificate sizes to see how much data it is ?
There was a problem hiding this comment.
for an ECDSA public key we would need 256bits. To support multiple algorithms 512bits should be enough for the key plus some additional bits to determine the algoritthm so let's reserve 520bits.
I'd also rename the certificate field - public_key would be more appropiate
does that sound good?
There was a problem hiding this comment.
Its not about the naming , but more about people being able to dump arbitrary data (potentialy 5 MB worth) into the field. This is why we are suggesting a bounded vec. It would also be nice to see some tests showing those bounds are enforced
There was a problem hiding this comment.
made the changes
andreea-popescu-reef
force-pushed
the
encrypt
branch
from
6bb6d24
to
b5d7c0e
Compare
as instructed by formalized_tensor
distributedstatemachine
dismissed
their stale review
need to revert changes to runtime api
Description
implemented logic for neuron certificate discovery and storage:
neuronInfo_getNeuronCertificate: ( netuid, hotkey ) --> certificatepallet storage for neuron certificatesfn get_neuron_certificate(netuid, neuron_uid)rpc to be called via bittensor library to fetch the certificate for a particular neuronfn serve_axon_tls(..., certificate)as an alternative for existingserve_axontaking an additional certificate parameter and storing itcompatible with older versions of bittensor as it doesn't modify the behaviour of existing rpc calls.
Checklist
rustfmtchanges