Indexed Preexecution Errors #788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
reviewed
Sep 17, 2024
sam0x17
approved these changes
Sep 17, 2024
sam0x17
requested changes
Sep 17, 2024
pallets/subtensor/tests/root.rs
Outdated
Comment on lines
1057
to
1084
| fn test_error_into_u8_conversion() { | ||
| new_test_ext(1).execute_with(|| { | ||
| let errors: Vec<Error<Test>> = vec![ | ||
| Error::<Test>::ColdkeyInSwapSchedule, | ||
| Error::<Test>::CommitWeightsBelowMinStake, | ||
| Error::<Test>::RevealWeightsBelowMinStake, | ||
| Error::<Test>::SetWeightsBelowMinStake, | ||
| Error::<Test>::SetRootWeightsBelowMinStake, | ||
| Error::<Test>::MaxIntervalRegistrationsReached, | ||
| Error::<Test>::SubNetworkDoesNotExist, | ||
| ]; | ||
|
|
||
| for error in errors { | ||
| let expected_value: u8 = match &error { | ||
| Error::<Test>::ColdkeyInSwapSchedule => 89, | ||
| Error::<Test>::CommitWeightsBelowMinStake => 90, | ||
| Error::<Test>::RevealWeightsBelowMinStake => 91, | ||
| Error::<Test>::SetWeightsBelowMinStake => 92, | ||
| Error::<Test>::SetRootWeightsBelowMinStake => 93, | ||
| Error::<Test>::MaxIntervalRegistrationsReached => 94, | ||
| _ => u8::MAX, | ||
| }; | ||
|
|
||
| let value: u8 = error.into(); | ||
| assert_eq!(value, expected_value); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
actually the whole point is you want to do a match on the enum itself so you get a compile error if something is missing / added, so this wouldn't be sufficient
sam0x17
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the preexecution error codes to ensure that the code matches its index in the metadata.
Related Issue(s)
Type of Change
Breaking Change