Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stake entries with zero stake #791

Open
wants to merge 5 commits into
base: devnet-ready
Choose a base branch
from
Open

Remove stake entries with zero stake #791

wants to merge 5 commits into from

Conversation

JohnReedV
Copy link
Contributor

@JohnReedV JohnReedV commented Sep 9, 2024 •
edited
Loading

Description

This PR:

  • Adds unstaking to remove_network
  • Adds migration to remove all stake entries with 0 stake.
  • Adds unit tests for remove_network and remove_zero_stakes_v1 migration

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

@JohnReedV JohnReedV marked this pull request as ready for review September 13, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@open-junius open-junius open-junius approved these changes

@unconst unconst Awaiting requested review from unconst unconst is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnReedV @open-junius