Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/runtime apis return types #832

Open
wants to merge 11 commits into
base: devnet-ready
Choose a base branch
from

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Sep 27, 2024

Description

Note: depends on opentensor/btcli#188

This PR is prepping for the ability to pull metadata straight from the nodes for use in decoding runtime API results.
The return types are only available in the metadata if they are set in the runtime API declarations.

To keep the RPCs, we will still be using the Vec<u8> encoding/decoding process in just the RPC call but the RuntimeAPIs will use the expected types as the client will now be expected to adjust when decoding based on the block metadata.

This change breaks the RuntimeAPIs, but not the RPCs. However, it guarantees that future RuntimeAPI changes will not break the client.

Related

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@camfairchild camfairchild marked this pull request as ready for review October 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants