Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] remove the assert on preferredChannelMask value #2026

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

abtink
Copy link
Member

@abtink abtink commented Sep 19, 2023


Should help address CI test failures in #2025

We have this line here in the test_dbus_client code:

    TEST_ASSERT(api->GetPreferredChannelMask(preferredChannelMask) == ClientError::ERROR_NONE);
    TEST_ASSERT(preferredChannelMask == 0x7fff800);

The value we expect is different from what we get as 134180864 or 0x7ff7000 in the CI runs (which I guess was changed as part of OpenThread PR openthread/openthread#9391)

This PR removes the assert check so to unblock #2025. We can re-add the check later (if we want) once the OT commit is updated on ot-br-posix and have the commit from openthread/openthread#9391.

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhui jwhui merged commit b7fddd2 into openthread:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants