[ncp] fix ncp spinel parsing methods #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2585 +/- ##
==========================================
- Coverage 55.77% 46.16% -9.62%
==========================================
Files 87 105 +18
Lines 6890 12575 +5685
Branches 0 912 +912
==========================================
+ Hits 3843 5805 +1962
- Misses 3047 6457 +3410
- Partials 0 313 +313 ☔ View full report in Codecov by Sentry. |
|
@Irving-cl , can you help resolve conflicts? |
Irving-cl
force-pushed
the
fix_ncp_parse_ip6_stream
branch
from
1e2b70b to
3356398
Compare
Irving-cl
force-pushed
the
fix_ncp_parse_ip6_stream
branch
from
3356398 to
0e517f6
Compare
|
@jwhui Conflict resolved! |
jwhui
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical issue in NcpSpinel parsing methods.
The parsing methods use
uint8_tas the length of input frame which is not sufficient for large frame like Ip6StreamNet, which could be at most 1000+ bytes.