Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] upgrade to gradle 8.2.2 #245

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

wgtdkp
Copy link
Member

@wgtdkp wgtdkp commented Mar 28, 2024

The gradle version is too old that it doesn't build with java 17. This
commit upgrades gradle to 8.2.2 as suggested by Android studio.

The changes in this commit are mostly auto-generated when apply
the suggested version by Android studio

@wgtdkp wgtdkp force-pushed the upgrade-gradle branch 2 times, most recently from 54c65a0 to dc14727 Compare March 28, 2024 11:40
@wgtdkp wgtdkp marked this pull request as draft March 28, 2024 11:57
@wgtdkp wgtdkp changed the title [build] upgrade to gradle 7.4.2 [build] upgrade to gradle 8.2.2 Mar 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.32%. Comparing base (5eea3b0) to head (3a65f7f).

❗ Current head 3a65f7f differs from pull request most recent head 3259bdc. Consider uploading reports for the commit 3259bdc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   73.33%   73.32%   -0.01%     
==========================================
  Files          71       71              
  Lines        7422     7420       -2     
==========================================
- Hits         5443     5441       -2     
  Misses       1979     1979              

see 2 files with indirect coverage changes

@wgtdkp wgtdkp force-pushed the upgrade-gradle branch 2 times, most recently from 37916ea to b4b8441 Compare March 28, 2024 12:16
@wgtdkp wgtdkp force-pushed the upgrade-gradle branch 4 times, most recently from 5920da8 to ea97b75 Compare March 29, 2024 11:32
@wgtdkp wgtdkp marked this pull request as ready for review March 29, 2024 11:33
@wgtdkp wgtdkp requested a review from librasungirl March 29, 2024 11:34
@wgtdkp wgtdkp force-pushed the upgrade-gradle branch 5 times, most recently from 5c6346e to 98923e5 Compare March 29, 2024 12:56
The gradle version is too old that it doesn't build with java 17.
This commit upgrades gradle to 8.2.2 as suggested by Android studio.
The changes in this commit are auto-generated when apply the suggested
version by Android studio.
Copy link
Contributor

@librasungirl librasungirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👍

@librasungirl librasungirl requested a review from jwhui March 29, 2024 13:25
@jwhui jwhui merged commit de8e82c into openthread:main Mar 29, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants