Lose forge items with maxContainer

[rokamdev]

Priority

Critical

Area

• Datapack
• Source
• Map
• Other

What happened?

If the player has the maximum limit of containers determined in "maxContainer" (config.lua) and makes a tier transfer at the forge on an item (traditional transfer or convergence), the provider item, the receiving item, the money and the exalted colors are removed and the “exaltation chest” container is not generated, along with a modal error on the screen.

ps: The first test I did was with the forging of two tier 0 items and the forge correctly returned the exaltation chest with the item inside, however after creating the issue, I carried out the test again with the forging of identical items and it presented the same transfer error, consuming all items and returning nothing.

What OS are you seeing the problem on?

Linux

Code of Conduct

• I agree to follow this project's Code of Conduct

[lBaah]

You can just put this after the getFreeBackpackSlots() check at Player::forgeFuseItems and Player::forgeTransferItemTier:

uint32_t maxContainer = static_cast<uint32_t>(g_configManager().getNumber(MAX_CONTAINER, FUNCTION));
auto backpack = getInventoryItem(CONST_SLOT_BACKPACK);
auto mainBackpack = backpack ? backpack->getContainer() : nullptr;
if (mainBackpack && mainBackpack->getContainerHoldingCount() >= maxContainer) {
sendCancelMessage(RETURNVALUE_CONTAINERISFULL);
return;
}

This is a shit workaround. The best to do is to refactor all the code to remove the items only if everything occured successfuly.

[helenarubra]

Several problem