Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Items Canary TFS 1.3 #449

Closed
5 tasks done
CzajaTwitch opened this issue Jul 22, 2022 · 7 comments · Fixed by #460
Closed
5 tasks done

Duplicate Items Canary TFS 1.3 #449

CzajaTwitch opened this issue Jul 22, 2022 · 7 comments · Fixed by #460
Labels
Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@CzajaTwitch
Copy link

Priority

Critical

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

A bug happened when I have 19 pages with loot in depot, The last two items throw out from 19 page on floor and item in depot not even move but in this way you duplicate item. This duplicate items can't be stack like normal items on each other.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@CzajaTwitch CzajaTwitch added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 22, 2022
@github-actions github-actions bot added map Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing labels Jul 22, 2022
@guispiller
Copy link
Contributor

Hey there, i don't understand exactly what you've said.
First of all, there's no such thing as "Canary TFS 1.3". Canary is one source, the only one supported here, and TFS is another different.
Which exactly item have you tested? just tried to put thing in a depot bot until page 19 and can't see nothing wrong
image

@CzajaTwitch
Copy link
Author

CzajaTwitch commented Jul 22, 2022 via email

@guispiller
Copy link
Contributor

guispiller commented Jul 22, 2022

Now i got it, critical issue!
Thanks for the report, we'll work on this

@CzajaTwitch
Copy link
Author

CzajaTwitch commented Jul 22, 2022 via email

@CzajaTwitch
Copy link
Author

CzajaTwitch commented Jul 22, 2022 via email

@CzajaTwitch
Copy link
Author

Now i got it, critical issue! Thanks for the report, we'll work on this

any update with the issue?

@dudantas
Copy link
Contributor

Now i got it, critical issue! Thanks for the report, we'll work on this

any update with the issue?

I'm investigating and trying to find the cause

dudantas added a commit that referenced this issue Jul 27, 2022
Resolves #449

With the wrong size, instead of getting all possible pages, it was stopping at the eighth page, which is the maximum number of items in uint8_t, so when there were more items it allowed to clone in a specific scenario, I will avoid giving examples so that they do not abuse the bug on the server of those who are not using the fix yet
luan pushed a commit that referenced this issue Jul 11, 2023
Resolves #449

With the wrong size, instead of getting all possible pages, it was stopping at the eighth page, which is the maximum number of items in uint8_t, so when there were more items it allowed to clone in a specific scenario, I will avoid giving examples so that they do not abuse the bug on the server of those who are not using the fix yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants