-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate Items Canary TFS 1.3 #449
Labels
Priority: Critical
Represents a risk to live servers
Status: Pending Test
This PR or Issue requires more testing
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
Comments
CzajaTwitch
added
the
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
label
Jul 22, 2022
github-actions
bot
added
map
Priority: Critical
Represents a risk to live servers
Status: Pending Test
This PR or Issue requires more testing
labels
Jul 22, 2022
Hey, make sure last three items it’s for example soulshredder, demon armor,
magic sword then throw it on floor
W dniu sob., 23.07.2022 o 00:08 Spiller ***@***.***>
napisał(a):
… Hey there, i don't understand exactly what you've said.
First of all, there's no such thing as "Canary TFS 1.3". Canary is one
source, the only one supported here, and TFS is another different.
Which exactly item have you tested? just tried to put thing in a depot bot
until page 19 and can't see nothing wrong
[image: image]
<https://user-images.githubusercontent.com/11639062/180579159-ae1e39d1-1d2e-47b8-945b-1f424193beef.png>
—
Reply to this email directly, view it on GitHub
<#449 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZXPXLLJOKZ5U7LDXOOJ77LVVMSVJANCNFSM54M56C5Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Now i got it, critical issue! |
W dniu sob., 23.07.2022 o 00:16 Spiller ***@***.***>
napisał(a):
… Hey, make sure last three items it’s for example soulshredder, demon
armor, magic sword then throw it on floor W dniu sob., 23.07.2022 o 00:08
Spiller *@*.
*> napisał(a): … <#m_-1355161114674158544_> Hey there, i don't understand
exactly what you've said. First of all, there's no such thing as "Canary
TFS 1.3". Canary is one source, the only one supported here, and TFS is
another different. Which exactly item have you tested? just tried to put
thing in a depot bot until page 19 and can't see nothing wrong [image:
image]
https://user-images.githubusercontent.com/11639062/180579159-ae1e39d1-1d2e-47b8-945b-1f424193beef.png
<https://user-images.githubusercontent.com/11639062/180579159-ae1e39d1-1d2e-47b8-945b-1f424193beef.png>
— Reply to this email directly, view it on GitHub <#449 (comment)
<#449 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZXPXLLJOKZ5U7LDXOOJ77LVVMSVJANCNFSM54M56C5Q
<https://github.com/notifications/unsubscribe-auth/AZXPXLLJOKZ5U7LDXOOJ77LVVMSVJANCNFSM54M56C5Q>
. You are receiving this because you authored the thread.Message ID: @.*>
Now i got it, critical issue!
Thanks for the report, we'll work on this
—
Reply to this email directly, view it on GitHub
<#449 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZXPXLNFZ5JHS7PUS7B2QOLVVMTT3ANCNFSM54M56C5Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sorry i have something else making my server crash. When player try sell
item to npc come message You cannot sell an imbued item. when player spam
it or few people at same time, few min later server dead
… Message ID: ***@***.***>
>
|
any update with the issue? |
I'm investigating and trying to find the cause |
Merged
dudantas
added a commit
that referenced
this issue
Jul 27, 2022
Resolves #449 With the wrong size, instead of getting all possible pages, it was stopping at the eighth page, which is the maximum number of items in uint8_t, so when there were more items it allowed to clone in a specific scenario, I will avoid giving examples so that they do not abuse the bug on the server of those who are not using the fix yet
luan
pushed a commit
that referenced
this issue
Jul 11, 2023
Resolves #449 With the wrong size, instead of getting all possible pages, it was stopping at the eighth page, which is the maximum number of items in uint8_t, so when there were more items it allowed to clone in a specific scenario, I will avoid giving examples so that they do not abuse the bug on the server of those who are not using the fix yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Critical
Represents a risk to live servers
Status: Pending Test
This PR or Issue requires more testing
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
Priority
Critical
Area
What happened?
A bug happened when I have 19 pages with loot in depot, The last two items throw out from 19 page on floor and item in depot not even move but in this way you duplicate item. This duplicate items can't be stack like normal items on each other.
What OS are you seeing the problem on?
Windows
Code of Conduct
The text was updated successfully, but these errors were encountered: