Added the vocation base id and the functions to manage it instead of the "client id" #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New lua function: vocation:getBaseId() New c++ function vocation->getBaseId() The idea of the base id is that the "promotions" have the same id as the base vocation, so that it is not necessary to have repetitions of ifs and if a new vocation is added, it will also not be necessary to register them in the scripts that call the vocations , because the id is the same. This function should only be used in scripts that will be used by all base vocations. For example, if a spell can be buy by the "knight" or "elite knight", then you can use vocation:getBaseId() It is always preferable to use vocation:getBaseId() when possible.
|
Kudos, SonarCloud Quality Gate passed!
|
dudantas
approved these changes
Aug 25, 2021
dudantas
changed the title
2 tasks
5 tasks
10 tasks
1 task
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
This change deals with the LuaScriptInterface decouple, being that totally organized and broken into files for each class. Totaling 105 new files properly organized. There are also some bug fixes and file indentation. Thanks and credits to @lgrossi and @foot, who helped with logic and how to decouple and fix all bugs. Co-authored-by: lgrossi <lucas.ggrossi@gmail.com> Co-authored-by: Renato Foot <costallat@hotmail.com>
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
…the "client id" (#11) New lua function: vocation:getBaseId() New c++ function vocation->getBaseId() The idea of the base id is that the "promotions" have the same id as the base vocation, so that it is not necessary to have repetitions of ifs and if a new vocation is added, it will also not be necessary to register them in the scripts that call the vocations , because the id is the same. This function should only be used in scripts that will be used by all base vocations. For example, if a spell can be buy by the "knight" or "elite knight", then you can use vocation:getBaseId() It is always preferable to use vocation:getBaseId() when possible.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New lua function: vocation:getBaseId()
New c++ function vocation->getBaseId()
The idea of the base id is that the "promotions" have the same id as the base vocation, so that it is not necessary to have repetitions of ifs and if a new vocation is added, it will also not be necessary to register them in the scripts that call the vocations , because the id is the same. This function should only be used in scripts that will be used by all base vocations.
For example, if a spell can be buy by the "knight" or "elite knight", then you can use vocation:getBaseId()
It is always preferable to use vocation:getBaseId() when possible.