Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple parses item attributes in it own file #140

Merged
merged 35 commits into from
Nov 23, 2021

Conversation

beats-dh
Copy link
Collaborator

@beats-dh beats-dh commented Oct 16, 2021

ItemParse has been refactored and decoupled in a own file to allow for better organization and avoid breakage in the compilation
Fixed some bugs, such as fields in items.xml
This commit is necessary for the pull request (12.72 protocol) to work correctly: #143

Co-authored by @dudantas eduardo.dantas@hotmail.com.br

@beats-dh beats-dh force-pushed the Use-switch-to-load-items.xml branch 3 times, most recently from 796f0c7 to 956b635 Compare October 18, 2021 19:45
@beats-dh beats-dh marked this pull request as ready for review October 18, 2021 19:47
@beats-dh beats-dh closed this Oct 21, 2021
@beats-dh beats-dh reopened this Oct 21, 2021
@dudantas dudantas changed the title Use switch to load items.xml Decouple parses item attributes in it own file Oct 22, 2021
@dudantas dudantas marked this pull request as draft October 23, 2021 01:00
@dudantas dudantas marked this pull request as ready for review October 27, 2021 22:27
data/events/scripts/player.lua Outdated Show resolved Hide resolved
data/events/scripts/player.lua Show resolved Hide resolved
src/items/items.cpp Outdated Show resolved Hide resolved
@dudantas dudantas marked this pull request as draft November 2, 2021 21:07
@dudantas dudantas mentioned this pull request Nov 4, 2021
8 tasks
@dudantas dudantas marked this pull request as ready for review November 23, 2021 18:34
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 304efb8 into opentibiabr:master Nov 23, 2021
beats-dh added a commit to beats-dh/canary that referenced this pull request Nov 29, 2021
beats-dh added a commit to beats-dh/canary that referenced this pull request Nov 29, 2021
@beats-dh beats-dh deleted the Use-switch-to-load-items.xml branch January 30, 2022 18:35
luan pushed a commit that referenced this pull request Jul 11, 2023
ItemParse has been refactored and decoupled in a own file to allow for better organization and avoid breakage in the compilation
Fixed some bugs, such as fields in items.xml
This commit is necessary for the pull request (12.72 protocol) to work correctly: #143

Co-authored-by @dudantas <eduardo.dantas@hotmail.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants