Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sale in the market to create offer by stash and adjust indentation to tab 4 #165

Merged
merged 9 commits into from
Dec 1, 2021
Merged

Fixed sale in the market to create offer by stash and adjust indentation to tab 4 #165

merged 9 commits into from
Dec 1, 2021

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Nov 25, 2021 •
edited
Loading

Description

When creating an offer with the item in the stash, it removed the item but did not create the offer.
Fixed the date when an item goes into history.
Thanks @gccris for the fixes.

Fixed indentation of functions:
playerCreateMarketOffer
playerCancelMarketOffer
playerAcceptMarketOffer

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@dudantas dudantas changed the title Fixed the sale in the market to create offer by stash Fixed the sale in the market to create offer by stash and indentation Nov 25, 2021
@dudantas dudantas changed the title Fixed the sale in the market to create offer by stash and indentation Fixed sale in the market to create offer by stash and indentation Nov 26, 2021
@dudantas dudantas changed the title Fixed sale in the market to create offer by stash and indentation Fixed sale in the market to create offer by stash and fix indentation Nov 26, 2021
@dudantas dudantas changed the title Fixed sale in the market to create offer by stash and fix indentation Fixed sale in the market to create offer by stash and adjust indentation to tab 4 Nov 26, 2021
@opentibiabr opentibiabr deleted a comment from github-actions bot Nov 26, 2021
@opentibiabr opentibiabr deleted a comment from github-actions bot Nov 26, 2021
@opentibiabr opentibiabr deleted a comment from github-actions bot Nov 26, 2021
@opentibiabr opentibiabr deleted a comment from github-actions bot Nov 26, 2021
@gccris gccris self-requested a review December 1, 2021 18:35
@opentibiabr opentibiabr deleted a comment from sonarcloud bot Dec 1, 2021
@dudantas dudantas merged commit a3e1d9e into master Dec 1, 2021
@dudantas dudantas deleted the market-fixes branch December 1, 2021 18:56
luan pushed a commit that referenced this pull request Jul 11, 2023
@dudantas
Fixed sale in the market to create offer by stash and adjust indentat…
0ea570d 
…ion to tab 4 (#165)

When creating an offer with the item in the stash, it removed the item but did not create the offer.
Fixed the date when an item goes into history.

Fixed indentation of functions:
playerCreateMarketOffer
playerCancelMarketOffer
playerAcceptMarketOffer

Co-authored by: @gccris
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beats-dh beats-dh beats-dh approved these changes

@gccris gccris gccris approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dudantas @gccris @beats-dh